Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] convertArrays should perform a shallow conversion instead of a deep conversion #30

Open
anthonyma94 opened this issue Jul 12, 2024 · 1 comment

Comments

@anthonyma94
Copy link

Loki's documentation is poor in this regard, but it actually supports arrays nested in an object:

logger.info(["hello", "world", 2]); // omitted
logger.info({ data: ["hello", "world", 2] }); // shows up

image

If the purpose of convertArrays is only to allow for ingest, I think it should only convert in cases where it would otherwise be omitted, i.e. top-level conversion. Currently it converts array in all levels:

image

@Julien-R44
Copy link
Owner

Hey! Indeed, looks like a bug. Happy to accept a PR for the same
Thankss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants