Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build constraints exclude all Go files in upiterrider/ffi@v0.1.0-beta.9 on darwin #4

Closed
Xuanwo opened this issue Aug 12, 2024 · 6 comments

Comments

@Xuanwo
Copy link

Xuanwo commented Aug 12, 2024

Hi, @JupiterRider. A user reported that github.com/jupiterrider/ffi failed to build on Darwin. I believe this library should be able to build on Darwin as well. Perhaps we should allow these files to build on Darwin?

For more context: apache/opendal#4996


I'm willing to help get this fixed. And maybe add some test in CI to cover.

@JupiterRider
Copy link
Owner

Hey @Xuanwo , I added macOS with 51655c1 .
You can try it by running go get github.com/jupiterrider/ffi@51655c1a7824d0d9cdbb4f9a533bca26b5f9e25.

@Xuanwo
Copy link
Author

Xuanwo commented Aug 12, 2024

Thanks for the prompt fix.

I don't have the device to help verify it. But I think I can contribute an integration test to avoid regression. What do you think?

@JupiterRider
Copy link
Owner

@Xuanwo After a little trail and error, I finally have a working CI workflow: 9dafd57

If you have any improvement suggestions, let me know or feel free to open a pull request.

@Xuanwo
Copy link
Author

Xuanwo commented Aug 13, 2024

@Xuanwo After a little trail and error, I finally have a working CI workflow: 9dafd57

If you have any improvement suggestions, let me know or feel free to open a pull request.

Hi, would you like to submit your changes as a PR to make it easier for us to collaborate?

@JupiterRider
Copy link
Owner

Of course. I created a pull request: #5

@JupiterRider
Copy link
Owner

macOS support is now live with v0.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants