Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LowPassFilter not follow pluglib interface #11

Open
jacknlliu opened this issue Nov 16, 2017 · 3 comments
Open

LowPassFilter not follow pluglib interface #11

jacknlliu opened this issue Nov 16, 2017 · 3 comments

Comments

@jacknlliu
Copy link

LowPassFilter implement did not follow the pluglib interface in which a constructor without parameters is required for classes. But here LowPassFilter has its parameters

LowPassFilter(double sampling_frequency = 0.0, double damping_frequency = 0.0, double damping_intensity = 0.0, double divider = 0.0);

And the LowPassFilter interface still works? It can't find in filters_plugin.xml.

@destogl
Copy link
Member

destogl commented Nov 16, 2017

Thank you for your comment. Yes there are some issues because we are currently in complete rewriting the filters.

Hopefully everything will be corrected soon.

@jacknlliu
Copy link
Author

Thanks for your reply. Hopefully, it works correctly soon. 👍

@destogl
Copy link
Member

destogl commented Jun 17, 2020

@jacknlliu is this still relevant for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants