Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing texture race condition #1

Open
xJon opened this issue Aug 28, 2024 · 7 comments
Open

Fix missing texture race condition #1

xJon opened this issue Aug 28, 2024 · 7 comments

Comments

@xJon
Copy link

xJon commented Aug 28, 2024

See rwtema/extrautilities_old_issues#1812, rwtema/Extra-Utilities-2-Source#178, rwtema/Extra-Utilities-2-Source#436, Krutoy242/Enigmatica2Expert-Extended#146.

Recently xJon/The-1.12.2-Pack#973.

Would be great to have a proper fix!

@Kanzaji
Copy link
Owner

Kanzaji commented Aug 30, 2024

Gonna take a look at this in my free time asap 😄 Thanks for the patch request.

@Kanzaji
Copy link
Owner

Kanzaji commented Sep 4, 2024

Okay this might be harder than it looked... it just worked in Dev >.>

20240904_142316.jpg

PS: Ignore phone photo - i was testing this at school lmao.

@xJon
Copy link
Author

xJon commented Sep 4, 2024

Indeed, that is why I referred to it as a race condition - perhaps you can try The 1.12.2 Pack to see the broken textures in action, although results can vary within the same modpack using different hardware.

@Kanzaji
Copy link
Owner

Kanzaji commented Sep 4, 2024

Indeed, that is why I referred to it as a race condition - perhaps you can try The 1.12.2 Pack to see the broken textures in action, although results can vary within the same modpack using different hardware.

The biggest issue with this (and most likely why Thema didn't touch this) is that I think I don't even have a way to debug this >.> So unless I somehow figure out why this is happening, it might be a really hard fix.

Not that I'm giving up on it, but I don't have time to look into this in the week ^^"

@xJon
Copy link
Author

xJon commented Sep 4, 2024

No worries - it is not urgent. What about simply changing the way the textures are applied?

@xJon
Copy link
Author

xJon commented Oct 17, 2024

Bumping this just in case it was forgotten 🙃

@Kanzaji
Copy link
Owner

Kanzaji commented Oct 17, 2024

No worries it wasn't 😄 I just didn't had a lot of time to look into this recently >.>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants