Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication does not work on non-fingerprint old devices (Don't mind Spanish, I have Spanish on school :( ) #23

Open
ian1ilych opened this issue Dec 26, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@ian1ilych
Copy link

Description

Screenshot_20221226-122548_Settings
Screenshot_20221226-122524_Keyspace

So my device is good up and running until it the app says that it took too long on authentication and so i realized this app needs a fingerprint, and my device dosen't had it.

Reproduction steps

1. Install the app on an old or older device running Android 9.0 or older
2. Sign in or Up with that device
3. Unlock the vault and Wait a few seconds or more, and done

Screenshots

No response

Device info

Galaxy J7 Star
Android 9.0
One UI 1.1
32 GB
2GB RAM
@ian1ilych ian1ilych added the bug Something isn't working label Dec 26, 2022
@ian1ilych ian1ilych changed the title Authentication does not work on non-fingerprint old devices Authentication does not work on non-fingerprint old devices (Don't mind Spanish, I have Spanish on school :( ) Dec 26, 2022
@0x4f53
Copy link
Member

0x4f53 commented Dec 26, 2022

Hi Ian, thanks for reporting this. We're investigating the issue and will get back to you.

0x4f53 pushed a commit that referenced this issue Dec 27, 2022
@0x4f53
Copy link
Member

0x4f53 commented Dec 27, 2022

Hey, I tried adding a biometric hardware check. Can you test this branch and tell me if you still face this issue?
https://github.com/Keyspace-cloud/android/tree/fingerprint_sensor_fix

@ian1ilych
Copy link
Author

It still has it.

@ian1ilych
Copy link
Author

ian1ilych commented Dec 27, 2022

Maybe try changing the behaviour of biometrics if it detects that it has fingerprint on your device, if it does not have it, then it will cancel and instead access normally and bypassing it.

@0x4f53
Copy link
Member

0x4f53 commented Dec 28, 2022

There's no way that can be done, since it goes against our security model of binding the Keyring to Keystore+BiometricPrompt (reference). I need to look into other fixes.

Interestingly enough, I tested this on a Moto G XT1033 from 2013 with an Android Pie Custom Rom and it worked just fine.

@ian1ilych
Copy link
Author

So the reason why it didn't worked is because i have an official operating system called the old One UI 1.1 and you used a custom operating system with ROM.

@ian1ilych
Copy link
Author

ian1ilych commented Jan 5, 2023

So it didn't worked, make sure it reads the model of the phone and its operating system (from most official brands), make sure it reads what brand made the model and the most important thing, what biometric supports

@Macmaster14
Copy link

Macmaster14 commented Jan 5, 2023 via email

@Macmaster14
Copy link

Macmaster14 commented Jan 5, 2023 via email

@ian1ilych
Copy link
Author

ian1ilych commented Jan 5, 2023

Im ian1ilych and basically:
The app had an issue where my device dosen't support fingerprints and the app needs it so im stuck with that image at the beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants