-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulate sampler lod bias #2163
Comments
I think it would be beneficial to rework how samplers are passed to Metal so that we pass the following data per sampler:
Then modify the shader to add bias (since bias is implemented in shader for Metal) and handle opaque black and as a nice side effect support custom border color (unsure if MoltenVK has support for this, I think not). Refer to KhronosGroup/Vulkan-Portability#37 (comment) for the custom border color. Mentioning this because it could be a unified effort to support bias and border color since both require similar changes. |
#2142 tries to tackle this issue exposing internal Metal SPIs. Unfortunately, even with
MVK_USE_METAL_PRIVATE_API
enabled, there are still CTS tests failing in the M3 chip family. Proposed solution is to emulate as pointed out in #2142 (comment)Failing CTS tests:
The text was updated successfully, but these errors were encountered: