Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in shader discard CTS test failures #2265

Open
billhollings opened this issue Jul 6, 2024 · 1 comment
Open

Regression in shader discard CTS test failures #2265

billhollings opened this issue Jul 6, 2024 · 1 comment
Assignees
Labels

Comments

@billhollings
Copy link
Contributor

There has been a recent regression in CTS fragment_shader_interlock discard tests. An additional 32 tests are failing.

The newly failing tests all seem to be those of type1xaa (one sample per pixel).

There are an existing set of 45 4xaa tests that were already failing, so it might be best to bundle all 77 of them altogether in a fix, rather than just addressing the 1xaa tests.

The full set of 576 fragment_shader_interlock tests is in this file: fragment-shader-interlock.txt

The full set of 77 failing fragment_shader_interlock tests is in this file: fragment-shader-interlock.txt-fails.txt

And the set of 32 newly-failing 1xaa tests that make up the regression are in this file: fragment-shader-interlock.txt-new-regression-fails.txt

@aitor-lunarg I'm wondering if this is related to your recent PR #2248, covering discard side-effects.

@aitor-lunarg aitor-lunarg self-assigned this Jul 8, 2024
@aitor-lunarg
Copy link
Collaborator

I just checked and it does make it fail. I'll provide a PR to revert that part of the change and investigate later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants