Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Conversion suite narrowing conversion errors #1157

Open
ellnor01 opened this issue Feb 12, 2021 · 1 comment
Open

Fix Conversion suite narrowing conversion errors #1157

ellnor01 opened this issue Feb 12, 2021 · 1 comment

Comments

@ellnor01
Copy link
Contributor

Enabling narrowing errors by removing
if(CMAKE_COMPILER_IS_GNUCC OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?Clang") add_cxx_flag_if_supported(-Wno-narrowing) endif()
in test_conformance/conversions/CMakeLists.txt produces many errors. A common example is:
test_conformance/conversions/basic_test_conversions.cpp:1624:5: error: narrowing conversion of '-125' from 'int' to 'unsigned int' inside { } [-Wnarrowing]
@ellnor01 ellnor01 mentioned this issue Feb 12, 2021
Open
@ellnor01
Copy link
Contributor Author

This is a follow up for #787 and so requires #1144 to be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ellnor01