Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage for CL_SEMAPHORE_HANDLE_LIST_KHR as part of cl_khr_semaphore tests #1875

Closed
nikhiljnv opened this issue Jan 15, 2024 · 1 comment
Closed

Test coverage for CL_SEMAPHORE_HANDLE_LIST_KHR as part of cl_khr_semaphore tests #1875

nikhiljnv opened this issue Jan 15, 2024 · 1 comment
Labels
mobica-backlog Issue approved by WG for Mobica to work on

Comments

@nikhiljnv
Copy link
Contributor

#1814 added minimal coverage for CL_MEM_HANDLE_LIST_KHR and CL_SEMAPHORE_HANDLE_LIST_KHR to external memory and external semaphore tests.
We need to cover CL_SEMAPHORE_HANDLE_LIST_KHR as part of cl_khr_semaphore tests as well.
In particular, we need -

  1. Semaphores are created with CL_SEMAPHORE_HANDLE_LIST_KHR property passed.
  2. The value of property containing 0, 1 and more than one devices to ensure appropriate behavior for clCreateSemaphoreWithPropertiesKHR
  3. CL_SEMAPHORE_HANDLE_LIST_KHR queried as part of clGetSemaphoreInfoKHR to ensure appropriate device list is returned.
@nikhiljnv nikhiljnv mentioned this issue Jan 16, 2024
Closed
9 tasks
@shajder shajder mentioned this issue Apr 9, 2024
Merged
nikhiljnv pushed a commit that referenced this issue Jun 4, 2024
@shajder
Added new query for cl_khr_semaphore test to verify device handle list (
806dd2f 
#1942)

This PR addresses the first part of #1691 issue and #1875 issue.
@kpet
Copy link
Contributor

kpet commented Jun 4, 2024

2024/06/04 Teleconference. There are a few cases that #1942 did not cover:

  • Perform the CL_SEMAPHORE_HANDLE_LIST_KHR query on a semaphore object created in a single-device context but without CL_SEMAPHORE_HANDLE_LIST_KHR. The device returned should be the one that the context was created from.
  • No coverage of multi-device contexts.

@neiltrevett neiltrevett added the mobica-backlog Issue approved by WG for Mobica to work on label Jul 9, 2024
@shajder shajder mentioned this issue Aug 29, 2024
Merged
bashbaug pushed a commit that referenced this issue Oct 15, 2024
@shajder @nikhiljnv
Added missing test cases for CL_SEMAPHORE_DEVICE_HANDLE_LIST_KHR quer…
2998463 
…ies (#2063)

According to comments from issue #1875

---------

Co-authored-by: Nikhil Joshi <nikhilj@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mobica-backlog Issue approved by WG for Mobica to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kpet @neiltrevett @nikhiljnv