Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating test_vulkan issues #1890

Open
MariaChizhova opened this issue Feb 7, 2024 · 1 comment
Open

Investigating test_vulkan issues #1890

MariaChizhova opened this issue Feb 7, 2024 · 1 comment

Comments

@MariaChizhova
Copy link

While investigating the test_vulkan buffer_single_queue on a recent Android version two problems surfaced:

  1. The usage of Core API functionality not available on the API version the instance is created with.
  • This can be fixed by either increasing the API version (to VK_API_VERSION_1_1), or by enabling and using the KHR extension function entrypoint (in our case it was vkGetBufferMemoryRequirements2KHR).
  1. Assumptions on supported handle types for VulkanBuffer.
  • Makes assumptions about VULKAN_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD being supported unconditionally.
  • Misses coverage for VK_EXTERNAL_MEMORY_HANDLE_TYPE_DMA_BUF_BIT_EXT, VK_EXTERNAL_MEMORY_HANDLE_TYPE_ANDROID_HARDWARE_BUFFER_BIT_ANDROID, and others depending on availability on a platform.

As the test is not finalized I hope this can be addressed.

@bashbaug
Copy link
Contributor

Hello!

We recently merged #2076, which should solve part (1).

Solving part (2) requires more significant work, and may be moved to a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants