Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify behavior in case of multiple clEnqueueAcquireExternalMemObjectsKHR calls on the same cl_mem #1086

Closed
nikhiljnv opened this issue Mar 22, 2024 · 4 comments
Closed

Clarify behavior in case of multiple clEnqueueAcquireExternalMemObjectsKHR calls on the same cl_mem #1086

nikhiljnv opened this issue Mar 22, 2024 · 4 comments

Comments

@nikhiljnv
Copy link
Contributor

Clarify behavior in case of multiple clEnqueueAcquireExternalMemObjectsKHR calls on the same cl_mem without corresponding clEnqueueReleaseExternalMemObjectsKHR.

This came up as part of KhronosGroup/OpenCL-CTS#1899
@nikhiljnv
Copy link
Contributor Author

Check how implementations behave if we do multiple acquires with earlier interops (GL/DX) as well as external sharing.

@nikhiljnv
Copy link
Contributor Author

Some options -

  1. Leave the behavior as implementation defined
  2. Return an error
  3. Recommend acquire to be used only once, but leave multiple acquires/release behavior implementation defined.

@bcalidas
Copy link

Option 3 looks to be best.

nikhiljnv added a commit that referenced this issue May 21, 2024
@nikhiljnv
Clarify Acquire/Release behavior for external memory
7304cf6 
Clarify Acquire/Release behavior for external memory specs
to call out the scope of operations as well as
the behavior in case of multiple acquire/release calls.

Fixes #1078, #1086
@nikhiljnv nikhiljnv mentioned this issue May 21, 2024
Merged
nikhiljnv added a commit that referenced this issue Jun 18, 2024
@nikhiljnv
Updates to Acquire/Release clarifications
eec1a09 
Address review comments on PR#1176

Fixes #1078, #1086
@nikhiljnv nikhiljnv mentioned this issue Jun 18, 2024
Merged
nikhiljnv added a commit that referenced this issue Jun 18, 2024
@nikhiljnv
Updates to Acquire/Release clarifications (#1183)
525e019 
Address review comments on PR#1176

Fixes #1078, #1086
bashbaug pushed a commit that referenced this issue Jul 16, 2024
@nikhiljnv @kpet
Clarify Acquire/Release behavior for external memory (#1176)
6be4f45 
* Clarify Acquire/Release behavior for external memory

Clarify Acquire/Release behavior for external memory specs
to call out the scope of operations as well as
the behavior in case of multiple acquire/release calls.

Fixes #1078, #1086

* Updates to Acquire/Release clarifications (#1183)

Address review comments on PR#1176

Fixes #1078, #1086

* Address left-over comments (#1194)

Address some of the comments that were
left out in earlier update.

* Fix the typo for "acquired"

Fix the typo suggested by Kevin to replace aquired to acquired.

Co-authored-by: Kévin Petit <kevin.petit@arm.com>

---------

Co-authored-by: Kévin Petit <kevin.petit@arm.com>
@bashbaug
Copy link
Contributor

This was fixed by #1176. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
OpenCL specification maintenance
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bashbaug @nikhiljnv @bcalidas