Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XML revision tag for extensions to generate specification revisions #1169

Open
EwanC opened this issue May 15, 2024 · 0 comments
Open

Use XML revision tag for extensions to generate specification revisions #1169

EwanC opened this issue May 15, 2024 · 0 comments

Comments

@EwanC
Copy link
Contributor

EwanC commented May 15, 2024

PR #1161 enforces that every extension defined by the XML must have a revision associated with it.

This revision will be used to generate an extension version in the headers, but it could also be used to generate the revision set in the human readable OpenCL specification. Currently, if an implementer wants to update the version of an extension they need to remember to update both the specification document and the XML entry. However, it would be less error prone to have the XML as the single source of truth that is used to generate the rendered specification document.

This may be blocked on #1168 so that all the revision XML entries are accurate, as we don't want to use the placeholder values in the rendered spec. Although we could check and only use the XML revision in the rendered specification if it isn't a placeholder value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant