-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(request) Provide git tags for matching Vulkan spec versions #345
Comments
There already are tags which correspond to the Vulkan SDK releases, which I think is what you should be using for the SDK components, not the Vulkan spec version. |
Those aren't updated for every spec version though. We want to be able to build software that uses the latest extensions. |
But, after a Vulkan update, which happens quite frequently, there isn't necessarily a new SPIR-V update to tag. The most recently tagged would be the most stable, but possibly missing the latest changes. What do you mean by "expect a specific version of spirv-headers"? If it's about a specific extension's tokens being present, it would be the spir-v commit that committed that extension (and if not yet tagged, then no one has yet formed a coherent SDK to tag as such). If about the latest features/extensions, that will be in the latest spir-v commit. If you mean all tested together as a coherent collection, I think that's what's getting tagged as @dgkoch mentioned. (There will be some tension between "all components fully tested together and tagged as such" versus "I need the latest extension from both Vulkan and SPIR-V".) |
For example the validation layers have tags for every Vulkan spec version, and those sometimes (like right now) depend on SPIRV symbols that aren't included in a tagged SDK release yet. So it would be nice to just know that a certain commit includes all the changes up to Vulkan spec version X. |
e.g. KhronosGroup/glslang@13.1.1...14.0.0#diff-ee9bb7072653a36092f3273394245c4151df04bb76c5afa22f0abf406320c0b2R15 |
There is still no tag since |
Thankyou @kpet for pushing https://github.com/KhronosGroup/SPIRV-Headers/releases/tag/vulkan-sdk-1.3.275.0 |
|
Hello! I'm working on packaging the Vulkan components for a Linux distribution, and we've been having some issues where things (notably the validation layers, but also some other tools) expect a specific version of spirv-headers, but there's no released tag for it. We can, of course, pick an arbitrary commit (and it seems to be what the VVL repo does for CI, at least), but it would be much nicer to have a specific tag that denotes "this includes all the changes as of Vulkan v1.x.xxx".
The text was updated successfully, but these errors were encountered: