Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(request) Provide git tags for matching Vulkan spec versions #345

Open
K900 opened this issue May 4, 2023 · 8 comments
Open

(request) Provide git tags for matching Vulkan spec versions #345

K900 opened this issue May 4, 2023 · 8 comments

Comments

@K900
Copy link

K900 commented May 4, 2023

Hello! I'm working on packaging the Vulkan components for a Linux distribution, and we've been having some issues where things (notably the validation layers, but also some other tools) expect a specific version of spirv-headers, but there's no released tag for it. We can, of course, pick an arbitrary commit (and it seems to be what the VVL repo does for CI, at least), but it would be much nicer to have a specific tag that denotes "this includes all the changes as of Vulkan v1.x.xxx".

@dgkoch
Copy link
Contributor

dgkoch commented May 5, 2023

There already are tags which correspond to the Vulkan SDK releases, which I think is what you should be using for the SDK components, not the Vulkan spec version.

See https://github.com/KhronosGroup/SPIRV-Headers/tags

@K900
Copy link
Author

K900 commented May 7, 2023

Those aren't updated for every spec version though. We want to be able to build software that uses the latest extensions.

@johnkslang
Copy link
Member

But, after a Vulkan update, which happens quite frequently, there isn't necessarily a new SPIR-V update to tag. The most recently tagged would be the most stable, but possibly missing the latest changes.

What do you mean by "expect a specific version of spirv-headers"? If it's about a specific extension's tokens being present, it would be the spir-v commit that committed that extension (and if not yet tagged, then no one has yet formed a coherent SDK to tag as such). If about the latest features/extensions, that will be in the latest spir-v commit.

If you mean all tested together as a coherent collection, I think that's what's getting tagged as @dgkoch mentioned.

(There will be some tension between "all components fully tested together and tagged as such" versus "I need the latest extension from both Vulkan and SPIR-V".)

@K900
Copy link
Author

K900 commented May 13, 2023

For example the validation layers have tags for every Vulkan spec version, and those sometimes (like right now) depend on SPIRV symbols that aren't included in a tagged SDK release yet. So it would be nice to just know that a certain commit includes all the changes up to Vulkan spec version X.

@daurnimator
Copy link

daurnimator commented Dec 24, 2023

@daurnimator
Copy link

There is still no tag since vulkan-sdk-1.3.268.0 back in october. How can we get tags for the commits selected by other components (such as glslang I linked above)

@daurnimator
Copy link

@daurnimator
Copy link

2acb319af38d43be3ea76bfabf3998e5281d8d12 as used at https://github.com/KhronosGroup/glslang/blob/fa9c3deb49e035a8abcabe366f26aac010f6cbfb/known_good.json#L15 is untagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants