Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix build after llvm commit d0ae2391 #2219

Merged

Conversation

wenju-he
Copy link
Contributor

d0ae2391 adds RunTimeLang parameter to createEnumerationType function.
Use default value for the new parameter.

d0ae2391 adds RunTimeLang parameter to createEnumerationType function.
Use default value for the new parameter.
@MrSidims
Copy link
Contributor

MrSidims commented Nov 16, 2023

Restarting CI to expose clang-format report, though IMO the formatting is OK in the patch
Ah, wait, it was clang-tidy

@MrSidims MrSidims closed this Nov 16, 2023
@MrSidims MrSidims reopened this Nov 16, 2023
@MrSidims
Copy link
Contributor

MrSidims commented Nov 16, 2023

Okay, that is what clang-tidy says, due to the fact, that it's taken from the nightly:
/home/runner/work/SPIRV-LLVM-Translator/SPIRV-LLVM-Translator/lib/SPIRV/SPIRVToLLVMDbgTran.cpp:805:32: error: too many arguments to function call, expected at most 10, have 11 [clang-diagnostic-error]

@MrSidims MrSidims merged commit 865af5d into KhronosGroup:main Nov 16, 2023
11 of 17 checks passed
@wenju-he wenju-he deleted the fix-build-createEnumerationType branch November 17, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants