Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec change] Add KHR for default context #944

Open
sycl-issue-bot bot opened this issue Sep 17, 2024 · 1 comment
Open

[Spec change] Add KHR for default context #944

sycl-issue-bot bot opened this issue Sep 17, 2024 · 1 comment

Comments

@sycl-issue-bot
Copy link

Please review whether KhronosGroup/SYCL-Docs#624 by @gmlueck requires any changes to the CTS.

If changes are required: Open a new PR addressing the changes and link it to this issue.
If no changes are required: Close this issue and proceed with the spec PR.

@gmlueck
Copy link
Contributor

gmlueck commented Sep 17, 2024

Yes, this PR requires additional CTS coverage:

  • Call platform::khr_get_default_context for the tested platform.
  • Create a queue using each constructor that that does not take an explicit context parameter.
  • Call queue::get_context on each of those queues and make sure the object compares equal to the object returned from platform::khr_get_default_context.

Note that this is a KHR, so the testing needs to be conditionally enabled based on whether the implementation defines the SYCL_KHR_DEFAULT_CONTEXT macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant