From c4d4c3231a370ab4434e30c27d6c41fba7d19332 Mon Sep 17 00:00:00 2001 From: Julien Duroure Date: Wed, 14 Aug 2024 07:08:56 +0200 Subject: [PATCH 1/2] fix_2317 --- addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py b/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py index f8bb8f568..c176dc346 100644 --- a/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py +++ b/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py @@ -365,7 +365,8 @@ def recursive_node_traverse(self, blender_object, blender_bone, parent_uuid, par self.recursive_node_traverse(dupl, None, node.uuid, parent_coll_matrix_world, new_delta or delta, blender_children, dupli_world_matrix=mat) # Geometry Nodes instances - if self.export_settings['gltf_gn_mesh'] is True: + # Maje sure to not check instances for instanced collection, because we will export what's inside the collection twice + if self.export_settings['gltf_gn_mesh'] is True and node.blender_type == VExportNode.OBJECT: # Do not force export as empty # Because GN graph can have both geometry and instances depsgraph = bpy.context.evaluated_depsgraph_get() From 8952e00e63e642cb9c5b65e7f47897f7c482494e Mon Sep 17 00:00:00 2001 From: Julien Duroure Date: Thu, 29 Aug 2024 18:33:44 +0200 Subject: [PATCH 2/2] fix comment typo --- addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py b/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py index c176dc346..79a69f722 100644 --- a/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py +++ b/addons/io_scene_gltf2/blender/exp/gltf2_blender_gather_tree.py @@ -365,7 +365,7 @@ def recursive_node_traverse(self, blender_object, blender_bone, parent_uuid, par self.recursive_node_traverse(dupl, None, node.uuid, parent_coll_matrix_world, new_delta or delta, blender_children, dupli_world_matrix=mat) # Geometry Nodes instances - # Maje sure to not check instances for instanced collection, because we will export what's inside the collection twice + # Make sure to not check instances for instanced collection, because we will export what's inside the collection twice if self.export_settings['gltf_gn_mesh'] is True and node.blender_type == VExportNode.OBJECT: # Do not force export as empty # Because GN graph can have both geometry and instances