Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken texture gathering on 4.1/4.1.1/4.2 #2278

Open
Lilaa3 opened this issue Jun 24, 2024 · 5 comments
Open

Broken texture gathering on 4.1/4.1.1/4.2 #2278

Lilaa3 opened this issue Jun 24, 2024 · 5 comments

Comments

@Lilaa3
Copy link

Lilaa3 commented Jun 24, 2024

Describe the bug
Gathering textures does not work on complex shader nodes, might have something to do with repeated sampling of the same texture (in my example used to recreate 3 point filtering)

To Reproduce
Export the provided file with default settings in binary or json mode, pause with a debugger to see the excessive recursion

Expected behavior
Either fail to gather anything and move on or find at least the first sampled texture

.blend file/ .gltf (mandatory)
example.blend.zip

Version

  • os: linux (debian based, specifally mint edge latest)
  • blender 4.1.1, not using flatpak

Additional context
These nodes are linked and manipulated automatically by fast64 and can have many combinations, including more than one texture being used with multiple samples, but if more convinient I can provide more examples

@Lilaa3 Lilaa3 changed the title Broken texture gathering on 4.1 Broken texture gathering on 4.1/4.1.1 Jun 24, 2024
@Lilaa3
Copy link
Author

Lilaa3 commented Jun 24, 2024

The addon is also fully failing to pick up on vertex colors being used in nodes

@julienduroure
Copy link
Collaborator

Hello,
I am not sure to get your entire node tree, as you didn't pack linked data.

As far as I can see (for now), your node setup doesn't have any Principled Shader node, so nothing can be exported, as glTF is based on PBR materials, so a Principled Node is needed.

You can refer to Blender Documentation to get what is compatible with glTF
https://docs.blender.org/manual/en/latest/addons/import_export/scene_gltf2.html

@julienduroure julienduroure added the question Further information is requested label Jun 24, 2024
@Lilaa3
Copy link
Author

Lilaa3 commented Jun 24, 2024

example.blend.zip
The issue isn´t that nothing can be exported, the addon seems to be trying to find textures during gather_image by iterating through the nodes, and its falling into some form of infinite recursion

@Lilaa3
Copy link
Author

Lilaa3 commented Jun 24, 2024

I also tested 4.2 and 4.3

@julienduroure julienduroure removed question Further information is requested labels Jun 25, 2024
@Lilaa3 Lilaa3 changed the title Broken texture gathering on 4.1/4.1.1 Broken texture gathering on 4.1/4.1.1/4.2 Jul 17, 2024
@Lilaa3
Copy link
Author

Lilaa3 commented Jul 17, 2024

@julienduroure I understand this is probably low prioraty but is there any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants