Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models for checking normal maps #57

Open
lexaknyazev opened this issue Jun 1, 2018 · 7 comments
Open

Models for checking normal maps #57

lexaknyazev opened this issue Jun 1, 2018 · 7 comments

Comments

@lexaknyazev
Copy link
Member

We need sample models for these cases (+ versions of these with morph targets):

Normals Tangents Normal map Engine's feature to check
Flat normals generation
✔️ MikkTSpace implementation with generated normals
✔️ ✔️ MikkTSpace implementation with provided normals

@bghgary Is it something glTF-Asset-Generator could assist with?

@bghgary
Copy link

bghgary commented Jun 1, 2018

Ignoring morph targets for now, these should be tested by glTF-Asset-Generator but it doesn't right now. We will add them. Morph targets are later in the road map.

For now, I have a separate test that we use to test this in Babylon. You can find the assets here: https://github.com/BabylonJS/Website/tree/master/Assets/TestCube. Live view here: http://www.babylonjs.com/demos/gltfnormals/

@emackey
Copy link
Member

emackey commented Jun 1, 2018

I believe the original NormalTangentTest model handles the last case, as it tests the engine's ability to generate the tangent vectors. A later model was added, NormalTangentMirrorTest that tests the engine's ability to load supplied tangents, which turned out to be less well-supported than generating the tangents.

@DRx3D
Copy link
Contributor

DRx3D commented Nov 2, 2023

@lexaknyazev @bghgary @emackey : Is there a need to keep this open, or should it be transferred to glTF-Sample-Assets repo. Default is to close by 27 Nov.

@donmccurdy
Copy link

I don't know of an example for "MikkTSpace implementation with generated normals" yet. I think the rest of this is resolved.

@lexaknyazev
Copy link
Member Author

This should be transferred.

@DRx3D DRx3D transferred this issue from KhronosGroup/glTF-Sample-Models Nov 24, 2023
@echadwick-artist
Copy link
Contributor

PR #88 might help here, as it represents the common workflow of baking normals from a high-resolution model down into a low-resolution model.

However it does not contain tangent data. Should it?

@donmccurdy
Copy link

I'd lean toward including the tangents — one less thing a tester needs to worry about, and we have other assets geared specifically toward testing correct handling of missing tangents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants