Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation criteria for models #72

Open
javagl opened this issue Nov 25, 2023 · 0 comments
Open

Validation criteria for models #72

javagl opened this issue Nov 25, 2023 · 0 comments

Comments

@javagl
Copy link
Contributor

javagl commented Nov 25, 2023

This issue is related to some other ones:

It is most closely related to the last one, namely to quality criteria in terms of validation. And it goes beyond the fact that all models MUST pass validation, which has already been established via CI.

The question here is in how far we should accept WARNING or HINT messages that are created by the validator. For example, I think that the sample assets repo should not contain models that have obvious 'unused objects'. Other warnings might be acceptable, depending on the context. (This particularly refers to extensions that are not (yet) handled by the validator, and which will create a WARNING that has to be aticipated)

The exact list of "acceptable issues" has to be sorted out. This might include some infrastructure for the automated tests. For example, roughly like a ignoredIssue.json file that explicitly ignores a certain warnings during the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant