diff --git a/ISSUES.md b/ISSUES.md index 052929a..5d17ed5 100644 --- a/ISSUES.md +++ b/ISSUES.md @@ -48,7 +48,6 @@ |KHR_MATERIALS_CLEARCOAT_CLEARCOAT_NORMAL_TEXTURE_TEXCOORD|Normal and clearcoat normal textures should use the same texture coords.|Warning| |KHR_MATERIALS_DISPERSION_NO_VOLUME|The dispersion extension needs to be combined with the volume extension.|Warning| |KHR_MATERIALS_EMISSIVE_STRENGTH_ZERO_FACTOR|Emissive strength has no effect when the emissive factor is zero or undefined.|Warning| -|KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID|Thickness maximum must be greater than or equal to the thickness minimum.|Error| |KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_WITHOUT_TEXTURE|Thickness minimum has no effect when a thickness texture is not defined.|Information| |KHR_MATERIALS_IRIDESCENCE_THICKNESS_TEXTURE_UNUSED|Thickness texture has no effect when the thickness minimum is equal to the thickness maximum.|Information| |KHR_MATERIALS_VOLUME_DOUBLE_SIDED|The volume extension should not be used with double-sided materials.|Warning| diff --git a/lib/src/errors.dart b/lib/src/errors.dart index 5f7b21b..b07e28f 100644 --- a/lib/src/errors.dart +++ b/lib/src/errors.dart @@ -547,12 +547,6 @@ class SemanticError extends IssueType { 'when a thickness texture is not defined.', Severity.Information); - static final SemanticError khrMaterialsIridescenceThicknessRangeInvalid = - SemanticError._( - 'KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID', - (args) => 'Thickness maximum must be greater than or ' - 'equal to the thickness minimum.'); - static final SemanticError khrMaterialsIridescenceThicknessTextureUnused = SemanticError._( 'KHR_MATERIALS_IRIDESCENCE_THICKNESS_TEXTURE_UNUSED', diff --git a/lib/src/ext/KHR_materials_iridescence/khr_materials_iridescence.dart b/lib/src/ext/KHR_materials_iridescence/khr_materials_iridescence.dart index be2071e..b5d2454 100644 --- a/lib/src/ext/KHR_materials_iridescence/khr_materials_iridescence.dart +++ b/lib/src/ext/KHR_materials_iridescence/khr_materials_iridescence.dart @@ -65,13 +65,6 @@ class KhrMaterialsIridescence extends GltfProperty { map, IRIDESCENCE_THICKNESS_TEXTURE, context, TextureInfo.fromMap); if (context.validate) { - if (iridescenceThicknessMinimum > iridescenceThicknessMaximum) { - context.addIssue( - SemanticError.khrMaterialsIridescenceThicknessRangeInvalid, - name: map.containsKey(IRIDESCENCE_THICKNESS_MINIMUM) - ? IRIDESCENCE_THICKNESS_MINIMUM - : IRIDESCENCE_THICKNESS_MAXIMUM); - } if (iridescenceThicknessTexture != null) { if (iridescenceThicknessMinimum == iridescenceThicknessMaximum) { context.addIssue( diff --git a/test/ext/KHR_materials_iridescence/assets.json b/test/ext/KHR_materials_iridescence/assets.json index 5bd0ad7..63ab3d5 100644 --- a/test/ext/KHR_materials_iridescence/assets.json +++ b/test/ext/KHR_materials_iridescence/assets.json @@ -4,7 +4,6 @@ "tests": { "custom_property.gltf": "Custom property", "unexpected_extension.gltf": "Unexpected extension object location", - "invalid_thickness_range.gltf": "Invalid thickness range", "unused_thickness_texture.gltf": "Unused thickness texture", "unused_thickness_minimum.gltf": "Unused thickness minimum", "valid.gltf": "Valid" diff --git a/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf b/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf deleted file mode 100644 index 3f5bbcb..0000000 --- a/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf +++ /dev/null @@ -1,47 +0,0 @@ -{ - "asset": { - "version": "2.0" - }, - "extensionsUsed": [ - "KHR_materials_iridescence" - ], - "materials": [ - { - "extensions": { - "KHR_materials_iridescence": { - "iridescenceFactor": 1, - "iridescenceThicknessMinimum": 500, - "iridescenceThicknessMaximum": 90, - "iridescenceThicknessTexture": { - "index": 0 - } - } - } - }, - { - "extensions": { - "KHR_materials_iridescence": { - "iridescenceFactor": 1, - "iridescenceThicknessMaximum": 90, - "iridescenceThicknessTexture": { - "index": 0 - } - } - } - }, - { - "extensions": { - "KHR_materials_iridescence": { - "iridescenceFactor": 1, - "iridescenceThicknessMinimum": 500, - "iridescenceThicknessTexture": { - "index": 0 - } - } - } - } - ], - "textures": [ - { } - ] -} \ No newline at end of file diff --git a/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf.report.json b/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf.report.json deleted file mode 100644 index 9023c87..0000000 --- a/test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf.report.json +++ /dev/null @@ -1,68 +0,0 @@ -{ - "uri": "test/ext/KHR_materials_iridescence/data/material/invalid_thickness_range.gltf", - "mimeType": "model/gltf+json", - "validatorVersion": "2.0.0-dev.3.8", - "issues": { - "numErrors": 3, - "numWarnings": 0, - "numInfos": 3, - "numHints": 0, - "messages": [ - { - "code": "KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID", - "message": "Thickness maximum must be greater than or equal to the thickness minimum.", - "severity": 0, - "pointer": "/materials/0/extensions/KHR_materials_iridescence/iridescenceThicknessMinimum" - }, - { - "code": "KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID", - "message": "Thickness maximum must be greater than or equal to the thickness minimum.", - "severity": 0, - "pointer": "/materials/1/extensions/KHR_materials_iridescence/iridescenceThicknessMaximum" - }, - { - "code": "KHR_MATERIALS_IRIDESCENCE_THICKNESS_RANGE_INVALID", - "message": "Thickness maximum must be greater than or equal to the thickness minimum.", - "severity": 0, - "pointer": "/materials/2/extensions/KHR_materials_iridescence/iridescenceThicknessMinimum" - }, - { - "code": "UNUSED_OBJECT", - "message": "This object may be unused.", - "severity": 2, - "pointer": "/materials/0" - }, - { - "code": "UNUSED_OBJECT", - "message": "This object may be unused.", - "severity": 2, - "pointer": "/materials/1" - }, - { - "code": "UNUSED_OBJECT", - "message": "This object may be unused.", - "severity": 2, - "pointer": "/materials/2" - } - ], - "truncated": false - }, - "info": { - "version": "2.0", - "extensionsUsed": [ - "KHR_materials_iridescence" - ], - "animationCount": 0, - "materialCount": 3, - "hasMorphTargets": false, - "hasSkins": false, - "hasTextures": true, - "hasDefaultScene": false, - "drawCallCount": 0, - "totalVertexCount": 0, - "totalTriangleCount": 0, - "maxUVs": 0, - "maxInfluences": 0, - "maxAttributes": 0 - } -} \ No newline at end of file