-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification on Unused Parameters in TimeLLM Forecast Function #116
Comments
Thank you very much for your interest in our work. Your understanding is correct. Currently, the variables x_mark_enc, x_dec, and x_mark_dec are not involved in the actual training process. We are using the Time-Series-Library framework for reference, and to maintain consistency, we have kept these parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Team,
Thanks for your great work! I'm currently working with the TimeLLM model as described in your ICLR paper, "Time-LLM: Forecasting and Understanding Time Series with Pretrained Language Models."
Upon reviewing the paper and the associated implementation, I noticed that the parameters
x_mark_enc
,x_dec
, andx_mark_dec
are passed to theforward
method but do not appear to be utilized in theforecast
function. Specifically, these parameters are passed through the method signatures but are not referenced within the function body for any operations or computations.Here's the relevant code snippet in
./Time-LLM/models/TimeLLM
:Is this the intended behavior, or are these parameters supposed to be used in a specific way that I'm missing?
Thank you for your time and consideration. I look forward to your guidance on this matter.
The text was updated successfully, but these errors were encountered: