Merge pull request #572 from teohhanhui/fix/flysystem-adapter-exists

Ensure correct return type from Flysystem adapter "exists" method
KnpLabs · May 29, 2018 · dd0d2e9 · dd0d2e9
2 parents 827dc53 + 5be9eae
commit dd0d2e9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/spec/Gaufrette/Adapter/FlysystemSpec.php b/spec/Gaufrette/Adapter/FlysystemSpec.php
@@ -45,6 +45,13 @@ function it_checks_if_file_exists(AdapterInterface $adapter)
  $this->exists('filename')->shouldReturn(true);
  }
 
+ function it_checks_if_file_exists_when_flysystem_returns_array(AdapterInterface $adapter)
+ {
+ $adapter->has('filename')->willReturn(['type' => 'file']);
+
+ $this->exists('filename')->shouldReturn(true);
+ }
+
  function it_fetches_keys(AdapterInterface $adapter)
  {
  $adapter->listContents()->willReturn([[

diff --git a/src/Gaufrette/Adapter/Flysystem.php b/src/Gaufrette/Adapter/Flysystem.php
@@ -50,7 +50,7 @@ public function write($key, $content)
  */
  public function exists($key)
  {
- return $this->adapter->has($key);
+ return (bool) $this->adapter->has($key);
  }
 
  /**