Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3 Adapter requires sockets and PCTNL extensions #586

Open
joshuaadickerson opened this issue Oct 16, 2018 · 1 comment
Open

AWS S3 Adapter requires sockets and PCTNL extensions #586

joshuaadickerson opened this issue Oct 16, 2018 · 1 comment
Assignees

Comments

@joshuaadickerson
Copy link

From this commit https://github.com/aws/aws-sdk-php/blob/3.69.0/composer.json they have required sockets and pctnl extensions for require-dev. This breaks tests because they are run in dev. This means this adapter now also requires those extensions.

You should cap the aws-sdk-php version at 3.68.1 for the current version and release a new major version of the adapter for the dependency changes.

@stof
Copy link
Contributor

stof commented Jan 21, 2021

dev requirements are a root-only feature. The dev requirements of aws/aws-sdk-php has strictly no influence when requiring it as a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants