Ratings changes do not always trigger a new overlay

[chazlarson]

Version Number

2.1.0--build22

What branch are you on?

nightly

Describe the Bug

Rating is updated, then overlay is not:

[INFO]     | Processing: 15/92 Breaking Bad                                                                     |
[INFO]     | Using imdb rating of 9.5                                                                           |
[INFO]     | Current 9.2 - new: 9.5                                                                             |
[INFO]     | Item Edits                                                                                         |
           | Update Critic Rating (Batched) | 9.5                                                               |
...
           | Breaking Bad                                                                                       |
[INFO]     |   Overlay Update Not Needed (Current Overlays: Overlay File (0) Rating1Fresh)                      |

These two lines:

[INFO]     | Using imdb rating of 9.5                                                                           |
[INFO]     | Current 9.2 - new: 9.5                                                                             |

Are log lines I added to operations.py to track what's going on.

Relevant Collection/Overlay/Playlist Definition

libraries:
  Kometa-TV:
    overlay_files:
    - default: ratings
      template_variables:
        rating1: critic
        rating1_style: '%'
        rating1_image: mdb
        horizontal_position: left
        vertical_position: top
    operations:
      mass_critic_rating_update:
      - imdb                    # IMDb Rating

Logs

https://gist.github.com/chazlarson/196adbca1213640963d1e8b18fd63695

[chazlarson]

It seems like the issue is that the actual rating is not in the compare string:

|   Overlay Update Not Needed (Current Overlays: Overlay File (0) Rating1Fresh)                      |
| {'text(<<critic_rating%>>)rating1_group100left3030topfonts/Inter-Bold.ttf63160160centertop15(255, 255, 255, 255)(0, 0, 0, 153)30150': 'Overlay File (0) Rating1Rotten'} |

Neither 9.2 nor 9.5 are encoded in there, so that change, which should trigger a reapply of the overlay, doesn't.

[chazlarson]

OK, no, the actual problem seems to be that the rating change from 9.2 to 9.5 is not recognized as a special text variable change, and it seems the wrong value is being used for the compare.

If I force the rating on everything to 2.2:

| Processing: 15/92 Breaking Bad                                                                     |
| Using 2.2 rating of 2.2                                                                            |
| Current 9.5 - new: 2.2                                                                             |
| Item Edits                                                                                         |
| Update Critic Rating (Batched) | 2.2                                                               |
...
| Breaking Bad                                                                                       |
|   Overlay Reason: Overlay changed Special Text Changed from 9.2 to 2.2                             |
|   Overlays Applied: Overlay File (0) Rating1Rotten                                                 |
| {'text(<<critic_rating%>>)rating1_group100left3030topfonts/Inter-Bold.ttf63160160centertop15(255, 255, 255, 255)(0, 0, 0, 153)30150': 'Overlay File (0) Rating1Rotten'} |

Where'd that 9.2 come from? The previous rating on BB was 9.5.

If I then force all ratings to 1.1:

| Processing: 15/92 Breaking Bad                                                                     |
| Using 1.1 rating of 1.1                                                                            |
| Current 2.2 - new: 1.1                                                                             |
| Item Edits                                                                                         |
| Update Critic Rating (Batched) | 1.1                                                               |
...
| Breaking Bad                                                                                       |
|   Overlay Reason: Overlay changed Special Text Changed from 9.5 to 1.1                             |
|   Overlays Applied: Overlay File (0) Rating1Rotten                                                 |
| {'text(<<critic_rating%>>)rating1_group100left3030topfonts/Inter-Bold.ttf63160160centertop15(255, 255, 255, 255)(0, 0, 0, 153)30150': 'Overlay File (0) Rating1Rotten'} |

Where did that 9.5 come from? The special text should have changed from 2.2 to 1.1.

Another oddball comparison value. It's not from some other item, since they all got updated from 2.2 to 1.1.