Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism to automagically return dex fee to taker if fail was not his fault #675

Closed
tonymorony opened this issue Jun 12, 2020 · 3 comments

Comments

@tonymorony
Copy link

Just something good to think about imo

Might be combined with NN relay nodes group idea #654

@cipig
Copy link
Member

cipig commented Jun 12, 2020

problem is that on high fee chains (BTC, ETH), the txfee for returning dexfee to taker can be higher than the dexfee itself

@tonymorony
Copy link
Author

as an idea for high fee chains refunds can be paid in KMD probably
anyway relay nodes will be connected to API endpoints which fetch USD prices so it'll be possible to calculate such ratio

@shamardy
Copy link
Collaborator

This is solved as part of the trading protocol upgrade #1895. There will be one transaction for the refund of the dex fee and the taker payment so this problem #675 (comment) is also be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants