Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in StoredResidueSubset?? #23

Open
frank-stonybrook opened this issue May 30, 2022 · 2 comments
Open

Small bug in StoredResidueSubset?? #23

frank-stonybrook opened this issue May 30, 2022 · 2 comments

Comments

@frank-stonybrook
Copy link

Dear FlexddG developers,

I read through the ddG-backrub.xml script and encounter this line that looks suspicious to me:

<PrimarySequenceNeighborhood name="bubble_adjacent" selector="bubble" lower="1" upper="1"/
<StoredResidueSubset name="restore_neighbor_shell" subset_name="neighbor_shell"/> 

where is this neighbor_shell subset being defined in the script? Shouldn't be the bubble_adjacent?

Thanks
Cong

@frank-stonybrook
Copy link
Author

Any insights on this?

@kylebarlow
Copy link
Member

Hi - the logic is a bit confusing, as the neighbor_shell subset isn't initialized until later when the protocol is running by the similarly named StoreResidueSubset mover, which uses the bubble_adjacent selector defined above in the residue selectors definition section. It's been a few years since a put all that together, so if that still seems wrong you probably know more than me, so please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants