Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of ores doesnt fully work #846

Open
Hojosa opened this issue Jun 9, 2024 · 1 comment
Open

Removal of ores doesnt fully work #846

Hojosa opened this issue Jun 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Hojosa
Copy link

Hojosa commented Jun 9, 2024

Minecraft Version

1.20.1

KubeJS Version

2001.6.5-build.7

Rhino Version

2001.2.2-build.6

Architectury Version

9.2.14

Forge/Fabric Version

NeoForge 47.1.105

Describe your issue

Using event.removeOres doesnt remove all ores listed, similar to #775

Script:
WorldgenEvents.remove(event => { event.removeOres(props => { props.worldgenLayer = 'underground_ores'; props.blocks = [ 'immersiveengineering:ore_lead', 'immersiveengineering:deepslate_ore_lead', 'immersiveengineering:ore_nickel', 'immersiveengineering:deepslate_ore_nickel', 'immersiveengineering:ore_silver', 'immersiveengineering:deepslate_ore_silver', 'mekanism:tin_ore', 'mekanism:deepslate_tin_ore' ] }) })

will only remove immersiveengineering:ore_silver. additionally, it seems to always be one from the list and the rest is not removed. i got another test setup (with more mods) where it only removed the nickel ore.
I also checked the source code of ImmersiveEngineering, and all Ores are placed in underground_ores, as far as i can tell.

Mods used:
ImmersiveEngineering-1.20.1-10.1.0-171
Mekanism-1.20.1-10.4.8.43
theoneprobe-1.20.1-10.0.2

Crash report/logs

No response

@Hojosa Hojosa added the bug Something isn't working label Jun 9, 2024
@desagas
Copy link

desagas commented Sep 22, 2024

Did you ever figure this out?

I have WorldgenEvents in my startup_scripts folder, but, every time I try to load it, I get this error in 1.21.1:
[ERROR] ! worldgen.js#1: dev.latvian.mods.rhino.EcmaError: ReferenceError: "WorldgenEvents" is not defined.

Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants