Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting pyx/pxd files into individual modules #5

Open
jkmacc-LANL opened this issue Jun 22, 2021 · 2 comments
Open

Consider splitting pyx/pxd files into individual modules #5

jkmacc-LANL opened this issue Jun 22, 2021 · 2 comments

Comments

@jkmacc-LANL
Copy link
Member

jkmacc-LANL commented Jun 22, 2021

Developing these two files is getting hairy, since they're getting rather long. It'd be easier to work on them as individual files, though it'd be harder to see how I solved coding problems in other classes when developing. cimport statements would have to be updated, as well.

https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#multiple-cython-files-in-a-package

@jkmacc-LANL
Copy link
Member Author

@rad-lanl I think it might be time for this, as our .pyx and .pxd are getting a little unwieldy. This should only effect development, as everything in Python-land would still be imported from .libgeotess. Would this cause you any issues? I'd do it later, after trying to bring in Rob's work...

@rad-lanl
Copy link
Contributor

Are you thinking individual pxd/pyx per class instance? that might cause some difficulty because of inheritance between classes, but if you can get it to work easily I don't foresee any issues on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants