Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

Merging fire Files #4

Open
tomeichlersmith opened this issue Jan 17, 2022 · 1 comment
Open

Merging fire Files #4

tomeichlersmith opened this issue Jan 17, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@tomeichlersmith
Copy link
Member

Combining files after a thorough skim would make analysis of the data much easier. I'm imagining another executable (written in C++ or Python) that would handle combining files in a way that preserves the necessary internal file relationships so that the output file can still be an input fire file and work with our ecosystem.

This would include managing the RunHeader dataset so that overwriting is prevented.

@tomeichlersmith tomeichlersmith added this to the v1.0.0 milestone Jan 17, 2022
@tomeichlersmith tomeichlersmith added the enhancement New feature or request label Feb 11, 2022
@tomeichlersmith tomeichlersmith pinned this issue Sep 29, 2022
@tomeichlersmith
Copy link
Member Author

I think writing it in C++ would be best, and I think we could include it in the fire executable by having sub-commands. For now, we would just have the new merge and the current run (which is the default if not subcommand is given), but it would then be easy to integrate other subcommands (e.g. a reformat for batch conversion of ROOT to HDF5).

int main(int argc, char* argv[]) {
  if (argc < 2) {
    usage();
    return 1;
  }
  std::string arg{argv[1]};
  if (arg == "merge") {
    return merge(argc-1, argv+1); 
  } else if (arg == "run") {
    return run(argc-1, argv+1);
  } else {
    return run(argc, argv);
  }
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant