Update cskburn-cli to v1.25

* Exit code is good on boundary error now :) Signed-off-by: xychen <xychen@listenai.com>
LISTENAI · May 29, 2024 · bce17ef · bce17ef
1 parent 6dcf631
commit bce17ef
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 13 deletions.
diff --git a/src-tauri/cskburn-cli/cskburn-aarch64-apple-darwin b/src-tauri/cskburn-cli/cskburn-aarch64-apple-darwin
diff --git a/src-tauri/cskburn-cli/cskburn-aarch64-unknown-linux-gnu b/src-tauri/cskburn-cli/cskburn-aarch64-unknown-linux-gnu
diff --git a/src-tauri/cskburn-cli/cskburn-x86_64-apple-darwin b/src-tauri/cskburn-cli/cskburn-x86_64-apple-darwin
diff --git a/src-tauri/cskburn-cli/cskburn-x86_64-pc-windows-msvc.exe b/src-tauri/cskburn-cli/cskburn-x86_64-pc-windows-msvc.exe
diff --git a/src-tauri/cskburn-cli/cskburn-x86_64-unknown-linux-gnu b/src-tauri/cskburn-cli/cskburn-x86_64-unknown-linux-gnu
diff --git a/src/App.vue b/src/App.vue
@@ -238,10 +238,6 @@ async function startFlash(): Promise<void> {
   output.value.splice(0);
   status.value = FlashStatus.CONNECTING;
 
-  // Workaround for cskburn bug that invalid addresses won't cause non-zero exit,
-  // while probing retries prints `ERROR:`.
-  let mayHaveError = false;
-
   let result: ICSKBurnResult | undefined;
   let error: unknown;
 
@@ -265,12 +261,6 @@ async function startFlash(): Promise<void> {
       onProgress(index, current) {
         progress.current = { index, progress: current };
       },
-      onError(_error) {
-        mayHaveError = true;
-      },
-      onFinished() {
-        mayHaveError = false;
-      },
     });
   } catch (e) {
     console.error(e);
@@ -292,9 +282,6 @@ async function startFlash(): Promise<void> {
   } else if (result?.code != null && result.code != 0) {
     status.value = FlashStatus.ERROR;
     output.value.push(`[烧录失败: 退出码 ${result.code}]`);
-  } else if (mayHaveError) {
-    status.value = FlashStatus.ERROR;
-    output.value.push('[烧录失败: 发生错误]');
   } else {
     status.value = FlashStatus.SUCCESS;
     output.value.push('[烧录成功]');