Skip to content

Commit

Permalink
bulk reactions for eliminated conc
Browse files Browse the repository at this point in the history
  • Loading branch information
tlroy committed Apr 3, 2024
1 parent 7ef2371 commit 356f8c8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions echemfem/solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ def steady_forms(self, us, v):
if gas_params:
Form += self.dissolutions(us, v, conc_params, gas_params)

# TODO: bulk_reactions and dissolutions for eliminated concentrations
# TODO: dissolutions for eliminated concentrations
# charge conservation
if self.flow["electroneutrality"]:
a, bc = self.charge_conservation_form(us,
Expand Down Expand Up @@ -1216,7 +1216,7 @@ def setup_bulk_reactions(self):
Setup using the law of mass action
"""
def bulk_reaction(u):
reactions = [0] * self.num_liquid
reactions = [0] * self.num_c
reaction_f = [0] * len(self.homog_params)
reaction_b = [0] * len(self.homog_params)
for idx, reaction in enumerate(self.homog_params):
Expand Down

0 comments on commit 356f8c8

Please sign in to comment.