-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/decide on API #20
Comments
You will find that many of these things are in there already, especially cutting on various things (for example, you could now specify lmin, lmax, zmin, zmax and it will cut for you and do the right thing with cov matrices), or you can cull correlations in different redshift bins, there are plotting routines already, etc. It also has an automatic and transparent cov/precision matrix inversion. It can store matrix as diagonal, block-diagonal or dense, however, for example if you store covariance as block diagonal and ask for precision, it will force it to dense on inversion, so not everything is done quite right. Having a general sparse matrix would also be useful. I don't think we'll ever need very complex linear algebra, our datasets will always be up to a few thousand elements in data vector and dense routines can invert this these days without issues. You can also has datasets that just specify cov matrix and another one that specifes the mean and load them up as a pair (useful for mocks when one cov matrix is there for many realizations). It can also coadd saccs in Cinvse way. However, our logic so far has been -- if you need something, code it up. I think it works pretty well as long as the basics are agreed. |
Yep the api has quite a bit of these things already. The goal here is to take stock of what is there, figure out what we want to do in addition, and make sure when we add everything it is all coherent. |
I have an issue in TreeCorr to support outputting to SACC format, but it sounds like maybe this isn't really stable yet. Especially given that there aren't any releases or tags for this repo yet. Please ping me on that issue when the API settles down and you think it would be worth it for me to work on that. I don't want to do something there if it will end up having to be redone when you change stuff over here. |
This issue has been dealt with in the v 0.2.0 release. |
To do:
We agreed to decide on an API and/or format for:
Some of this exists and other parts do not yet.
We also want APIs for:
The text was updated successfully, but these errors were encountered: