Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package maintenance #124

Open
rudiedirkx opened this issue Feb 27, 2023 · 10 comments
Open

Package maintenance #124

rudiedirkx opened this issue Feb 27, 2023 · 10 comments

Comments

@rudiedirkx
Copy link

rudiedirkx commented Feb 27, 2023

I've asked everywhere and nobody is responding, so this will be the last time:

I'd like to help/take over maintaining this annotations package. I'd hate to see it disappear, because I love it.


For now, I've created a fork with all PRs included: https://github.com/rudiedirkx/laravelcollective-annotations but it would be much better if this actual package survived.

You can use the fork by adding a custom repository in your project's composer.json:

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/rudiedirkx/laravelcollective-annotations.git"
    }
],

and then require that version specifically:

"laravelcollective/annotations": "dev-8.0-fork as 8.1",

It works, but it's silly, but I hope it won't be necessary for long.

@Putr
Copy link

Putr commented Mar 28, 2023

Damn ... I really wish they would let you take it over.

If nothing else ... we need Laravel9&10 support.

Can I help you add Laravel 9 support on your branch, while we try and get you access to the repo?

@rudiedirkx
Copy link
Author

It has Laravel 9 support in branch 8.0-fork. I'm not on L 10 yet, so I can't test that, but I assume it would work for L 10 too.

I can't reach anyone with maintainer access, so I don't see any development ahead =( You're very welcome to try of course.

@Putr
Copy link

Putr commented Mar 29, 2023

Thank you for the 8.0-fork info, you just saved me A LOT of headache.

I've sent an email – as have you, probably. I'll see what else I can do. Not only that, but I depend on this project a lot, so when you take over (yes, I'm very optimistic) I'm willing to help out.

@loonytoons
Copy link
Collaborator

@mlantz anything you can do to help here?

@rudiedirkx
Copy link
Author

I've updated 8.0-fork to include laravel 10 support, because that seems to work. I've tested only briefly, and only with Doctrine annotations, not PHP Attributes.

@letharion
Copy link

I just found https://laravelcollective.com/thanks, which in wayback machine appears for the first time in May.
It seems like the whole namespace is just abandoned, so I guess it's time to move on.
The fork has served me well for some time, but I guess I will take a look at the recommended alternative spatie/laravel-route-attributes and see if that's a reasonable option.

@rudiedirkx
Copy link
Author

They also abandoned laravelcollective/html and recommend spatie/laravel-html, but those aren't compatible at all. Such a waste. I'll never understand why they didn't just accept our help and keep laravelcollective alive =(

@letharion
Copy link

It's a pretty sad way to go, when you specifically are asking to help.
@rudiedirkx Do you intend to maintain the fork going forward? It would be nice if this could continue, albeit under a new package name. Since I currently use it extensively I could at the very least provide help testing it.

@rudiedirkx
Copy link
Author

Yes, I want to keep using it, so I'll maintain it, but there's not much maintenance necessary I think.

@rudiedirkx
Copy link
Author

rudiedirkx commented Aug 10, 2023

I've changed how requiring my fork works. Instead of "repositories" and "dev-8.0-fork as 8.1" like I said in the OP, now you:

  1. composer require rdx/laravelcollective-annotations
  2. remove the "repositories" entry for this repo
  3. composer remove laravelcollective/annotations

That installs stable rdx/laravelcollective-annotations 8.2 from Packagist, and replaces laravelcollective/annotations. All package code still works. "replace" is a Composer feature exactly for this purpose.

You only have to do this when you upgrade/update/require/remove something in your composer.json. If your composer.json doesn't change, you're fine, but next time it does, don't forget this. The "repositories" trick won't work anymore.


I've done the same for laravelcollective/html: require rdx/laravelcollective-html (6.6) and remove laravelcollective/html. All other packages will think laravelcollective/html is installed, and everything works like magic. Composer (and "replace") is brilliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants