Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove variants and related methods from Actionlike #412

Closed
alice-i-cecile opened this issue Nov 11, 2023 · 0 comments · Fixed by #452
Closed

Remove variants and related methods from Actionlike #412

alice-i-cecile opened this issue Nov 11, 2023 · 0 comments · Fixed by #452
Labels
code-quality Make the code faster or prettier usability Reduce user friction
Milestone
0.12

Comments

@alice-i-cecile
Copy link
Contributor 

          There are still quite a bit of `A::variants()` usage left. I'm kinda surprised that it has not broken anything else like it did. Is it within the scope of this pr to remove usage of `A::variants()` as you mentioned on Discord? The removal of `A::variants()` will not be trivial, I think. For `InputMap` it can use `iter()`, but `ActionState` doesn't have access to the map so it will require some thought.

Originally posted by @100-TomatoJuice in #400 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Make the code faster or prettier usability Reduce user friction
Projects
None yet
Milestone
0.12
1 participant
@alice-i-cecile