Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed GET_WALLET_PUBKEY causes app to halt #3

Open
apoelstra opened this issue Mar 27, 2017 · 0 comments
Open

Malformed GET_WALLET_PUBKEY causes app to halt #3

apoelstra opened this issue Mar 27, 2017 · 0 comments

Comments

@apoelstra
Copy link

In https://github.com/LedgerHQ/blue-app-btc/blob/master/src/btchip_helpers.c#L220-L222 there is a THROW which is easy to trigger by sending a GET_WALLET_PUBKEY with BIP32 chain longer than 10. The app then halts and will refuse to answer future messages until the user exists and re-enters it.

This has a benefit, I can trigger it intentionally, e.g. if my PC application thinks it's being attacked and wants to quickly disable the dongle. But it would probably be better to have a dedicated message for this.

A more consistent behaviour would be to return BTCHIP_SW_INCORRECT_DATA to the caller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant