From 98f2019821bd835a247eebbf5407328836f588e5 Mon Sep 17 00:00:00 2001 From: Alexis Grojean Date: Mon, 20 Nov 2023 14:52:09 +0100 Subject: [PATCH] Code cleanup --- src/app_ui/sign.rs | 5 ++--- src/handlers/sign_tx.rs | 2 +- src/main.rs | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/app_ui/sign.rs b/src/app_ui/sign.rs index effa09e..5356c7f 100644 --- a/src/app_ui/sign.rs +++ b/src/app_ui/sign.rs @@ -16,11 +16,10 @@ *****************************************************************************/ use crate::handlers::sign_tx::Tx; -use crate::AppSW; use ledger_device_ui_sdk::bitmaps::{CROSSMARK, EYE, VALIDATE_14}; use ledger_device_ui_sdk::ui::{Field, MultiFieldReview}; -pub fn ui_display_tx(tx: &Tx) -> Result { +pub fn ui_display_tx(tx: &Tx) -> bool { // Define transaction review fields let my_fields = [ Field { @@ -48,5 +47,5 @@ pub fn ui_display_tx(tx: &Tx) -> Result { Some(&CROSSMARK), ); - Ok(my_review.show()) + my_review.show() } diff --git a/src/handlers/sign_tx.rs b/src/handlers/sign_tx.rs index 9c4a9dc..77ab40e 100644 --- a/src/handlers/sign_tx.rs +++ b/src/handlers/sign_tx.rs @@ -100,7 +100,7 @@ pub fn handler_sign_tx( // Display transaction. If user approves // the transaction, sign it. Otherwise, // return a "deny" status word. - if ui_display_tx(&tx)? { + if ui_display_tx(&tx) { return compute_signature_and_append(comm, ctx); } else { return Err(AppSW::Deny); diff --git a/src/main.rs b/src/main.rs index f9db80a..4ab4d7f 100644 --- a/src/main.rs +++ b/src/main.rs @@ -44,7 +44,6 @@ use handlers::{ ledger_device_sdk::set_panic!(ledger_device_sdk::exiting_panic); -use ledger_device_sdk::testing::debug_print; // CLA (APDU class byte) for all APDUs. const CLA: u8 = 0xe0; // P2 for last APDU to receive.