Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screens serialization not symmetric #22

Closed
jnicoulaud-ledger opened this issue Sep 24, 2024 · 1 comment · Fixed by #30
Closed

Screens serialization not symmetric #22

jnicoulaud-ledger opened this issue Sep 24, 2024 · 1 comment · Fixed by #30
Labels
bug Something isn't working

Comments

@jnicoulaud-ledger
Copy link
Contributor

We lose some data when saving/reloading:

            'stax': [
              {
+               'type': 'propertyPage',
+               'label': 'DAI Permit',
+               'content': [
+                 'spender',
+                 'value',
+                 'deadline',
+               ],
              },
            ],
          },
@jnicoulaud-ledger jnicoulaud-ledger added the bug Something isn't working label Sep 24, 2024
ClaireGuerreGiordano added a commit that referenced this issue Sep 25, 2024
@ClaireGuerreGiordano
Screens serialization not symmetric #22
7e01591
@ClaireGuerreGiordano ClaireGuerreGiordano linked a pull request Sep 25, 2024 that will close this issue
Screens serialization not symmetric #22 #30
Merged
@ClaireGuerreGiordano
Copy link
Collaborator

I was not able to reproduce this bug. I thus added a test aiming to reproduce it (and passing)

ClaireGuerreGiordano added a commit that referenced this issue Sep 25, 2024
@ClaireGuerreGiordano
Screens serialization not symmetric #22
6e5a94b
jnicoulaud-ledger pushed a commit that referenced this issue Sep 26, 2024
@ClaireGuerreGiordano
Screens serialization not symmetric #22 (#30)
7e43103 
* Screens serialization not symmetric #22

* Rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Screens serialization not symmetric #22 LedgerHQ/python-erc7730
2 participants
@ClaireGuerreGiordano @jnicoulaud-ledger