Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing at KIT: Wash list #63

Open
6 of 9 tasks
uellue opened this issue Nov 17, 2022 · 4 comments
Open
6 of 9 tasks

Testing at KIT: Wash list #63

uellue opened this issue Nov 17, 2022 · 4 comments
Milestone

Comments

@uellue
Copy link
Member

uellue commented Nov 17, 2022

  • Make Blobfinder PR for UDF parameter passthrough Pass arbitrary parameters to run_udf() LiberTEM-blobfinder#42
  • Set header detail configuration resp. deal with missing header
    - A missing config value made the Dectris detector error out and send a different header than expected
    - The acquisition parameter for header details should be set to "basic" in the trigger function
  • When running fast there were issues with missing headers that caused crashes. This should be handled gracefully by erroring out, not with a hard crash of the receiver.
    - Send dropped frame messages when skips in frame ID are detected
  • The base shape check has been patched out of the LiberTEM source code at KIT. Re-evaluate and fix root cause.
  • Display messages in case of errors for debuggability
  • Documentation in libertem-rs repo: Libertem-dectris-rs requires additionally: cmake, clang, libclang, set LIBCLANG_PATH in case conda is used
  • Option to drain data from ZeroMQ based on series ID? One may receive data from a previous series if that was not consumed completely.
  • When cancelling the acquisition, the pipelined executor sometimes doesn't work for the next UDF run (might need a slight design change)
  • Detctor status display widget would be really helpful
@uellue uellue added this to the 0.2 milestone Nov 17, 2022
@sk1p
Copy link
Member

sk1p commented Nov 23, 2022

Option to drain data from ZeroMQ based on series ID? One may receive data from a previous series if that was not consumed completely

At the beginning of the acquisition, this is now done, discarding messages that don't belong to the current series.

@sk1p
Copy link
Member

sk1p commented Mar 29, 2023

Set header detail configuration resp. deal with missing header

This is done in #74 - streaming is enabled automatically and header_detail is set to 'basic' in both the active and the passive use case.

@sk1p
Copy link
Member

sk1p commented Mar 29, 2023

Display messages in case of errors for debuggability

Logging can be enabled, which outputs debug information, not only for errors but also for other details, if the level is set to 'info' or 'debug'.

@sk1p
Copy link
Member

sk1p commented Mar 29, 2023

When cancelling the acquisition, the pipelined executor sometimes doesn't work for the next UDF run

This should be fixed also, at least in LiberTEM v0.11 - the corresponding test case runs another UDF after the previous run_udf call err'd out. This now seems to work quite reliable.

The only thing where one has to take a bit care is the connection objects - if you create a new one without closing the previous one (for example, you re-run the notebook cell that connects to the detector system), you will still get issues. This needs to be properly documented, and we need to also provide plenty examples where this is properly handled.

@sk1p sk1p modified the milestones: 0.2, 0.3 Apr 19, 2023
@sk1p sk1p modified the milestones: 0.3, 0.4 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants