Update +S logic for single-# channels #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Policy regarding single-# channels was semi-recently updated such that informal channels are allowed there as second-class citizens to registered project and community channels. With this change, it doesn't make sense to override successor on single-# informal channels to hardcode libera-placeholder-account. Modify the logic so that we only override the successor on channels belonging to a registered project's namespace, while leaving informal channels to default +S behaviour. Since this now depends on project status, the module has been moved to the projectns/ subdirectory and given a more accurate module name for the new functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policy regarding single-# channels was semi-recently updated such that informal channels are allowed there as second-class citizens to registered project and community channels. With this change, it doesn't make sense to override successor on single-# informal channels to hardcode libera-placeholder-account.
Modify the logic so that we only override the successor on channels belonging to a registered project's namespace, while leaving informal channels to default +S behaviour.
Since this now depends on project status, the module has been moved to the projectns/ subdirectory and given a more accurate module name for the new functionality.