-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOOKINGSG-6090][JZ|FY] Add DateNavigator and TimeTable component #578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta to render bookings
…introduce stories for it
…rops optional, with defaults
…dding and overriding offset value
…t popover from disappearing on parent re-render due to scroll action
…eader column to trigger popover on hover
…ll handler, removed some unnecessary props
…, create function buildPopoverTrigger to allow us to apply the custom popover styles by targetting popoverClassName
…overSize to timetableprops to allow SI to pass in custom styling for popover
…ll, also improved on scrolling re-render
…ows into its own folder
…ol and amend bottom padding for timetable content to be 0 when no pagination is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added TimeTable component
Added DateNavigator component
Update Popover to accept optional offset and delay props to configure the offset/delay, defaults to existing fixed values
[delete] branch
Changelog entry
Added DateNavigator component to facilitate date display and navigation with date navigation callbacks.
Added TimeTable component to facilitate listing displays and its statuses across a time range, with lazy loading, empty content, custom popovers, and click functionalities.
Updated Popover to allow offset/delay props to be customisable, defaults to the existing fixed values of offset=16, delay={open:0, close: 500}.
Additional information