[BOOKINGSG-6120][JH] additional timeRangePicker combobox fixes #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- external error to hide dropdown as well - invalid time range validation to keep values instead of auto clearing - trigger blur event when clicking outside the input on the error message
qroll
requested changes
Sep 30, 2024
qroll
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixed
errorMessageprop to hide dropdown as well (only internal validation was doing this previously)modified invalid time range validation behavior to keep values instead of auto clearing end value
fixed bug where clicking outside the input, on the error message was not triggering the blur event
split tab behavior test case to (hopefully) fix test case sometimes failing on gitlab pipeline
[delete] branch