Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies/itests & remove vault(secret) function #10

Merged
merged 12 commits into from
Aug 12, 2024

Conversation

nvima
Copy link

@nvima nvima commented Aug 9, 2024

  • Migrated CircleCi -> Github Actions
  • Updated Dependencies & Gradle
  • Migrated integrationTest Projects into integrationMain SourceSet
  • Removed vault(secret) function
  • Removed afterEvaluate in Task Configuration
  • Use version catalog for dependencies

Patrick Mirwald added 12 commits August 7, 2024 16:32
- Renamed vault.docker to vault.Dockerfile for better LSP recognition
- Updated docker-compose.yml to reference the new filename
- Simplified Dockerfile contents
Update gradle-wrapper.properties to use Gradle 8.9 distribution
- Upgrade com.gradle.plugin-publish to 1.2.1
- Upgrade net.nemerosa.versioning to 3.1.0
- Remove obsolete tasks and configurations
- Simplify plugin metadata setup
- Add integration test source set
- Remove obsolete integration test projects
- Implement integration test into new setup
- Update Gradle plugin versions using version catalog
- Refactor unit tests to use JUnit 5
This should cover the removal of afterEvaluate, i wanted to test if we
still can get different secrets with one extension.
@nvima
Copy link
Author

nvima commented Aug 9, 2024

@Ingwersaft
Can u verify that these secrets are set in github settings:
env: GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }} GRADLE_PUBLISH_SECRET: ${{ secrets.GRADLE_PUBLISH_SECRET }}

When the MR is too big, i can also split it up.

@nvima nvima self-assigned this Aug 9, 2024
@nvima nvima requested a review from Ingwersaft August 9, 2024 11:38
Copy link
Member

@Ingwersaft Ingwersaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ingwersaft Ingwersaft merged commit f081e21 into master Aug 12, 2024
1 check passed
@Ingwersaft Ingwersaft deleted the chore/renovate_plugin branch August 12, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants