-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies/itests & remove vault(secret) function #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvima
commented
Aug 9, 2024
- Migrated CircleCi -> Github Actions
- Updated Dependencies & Gradle
- Migrated integrationTest Projects into integrationMain SourceSet
- Removed vault(secret) function
- Removed afterEvaluate in Task Configuration
- Use version catalog for dependencies
- Renamed vault.docker to vault.Dockerfile for better LSP recognition - Updated docker-compose.yml to reference the new filename - Simplified Dockerfile contents
Update gradle-wrapper.properties to use Gradle 8.9 distribution
- Upgrade com.gradle.plugin-publish to 1.2.1 - Upgrade net.nemerosa.versioning to 3.1.0 - Remove obsolete tasks and configurations - Simplify plugin metadata setup
- Add integration test source set - Remove obsolete integration test projects - Implement integration test into new setup - Update Gradle plugin versions using version catalog - Refactor unit tests to use JUnit 5
This should cover the removal of afterEvaluate, i wanted to test if we still can get different secrets with one extension.
@Ingwersaft When the MR is too big, i can also split it up. |
Ingwersaft
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.