-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
catching also PL deprecation warnigs #24
Labels
Projects
Comments
to just catch the deprecation warnings as an error, we need to somehow catch LightningDeprecationWarning from pytorch-lightning. but here pytorch-lightning is an external package, so we need to figure out how we can do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
馃殌 Feature
if we want to be progressive incompatibility we shall also report on deprecation warnings and eventually treat them as failer...
as an alternative, we can give a user option to set it as strict 馃
Pitch
Compatibility for the future
Alternatives
pass pytest argument
-W error::DeprecationWarning
inhttps://github.com/PyTorchLightning/ecosystem-ci/blob/c544b7bc10fbef6f6b498805dd08837eb1ba96a2/actions/_config.yaml#L54
Additional context
https://docs.pytest.org/en/latest/how-to/capture-warnings.html#controlling-warnings
The text was updated successfully, but these errors were encountered: