Support for com.google.rpc.Status ?

[benallard]

So, by defining a GRpcServerAdvice, one can customize how exceptions are being translated to proper grpc error Status (io.grpc.Status). While those are nice, beside code, description and cause, there isn't much one can set.

The com.google.rpc.Status additionally allows a details field with domain, reason, and even generic metadata.

Is there a way to define a sort of ServerAdvice that outputs the more verbose Status object ? (And, of course to get it into the client?)

[jvmlet]

Just return Status object from your advice built with standard api https://github.com/grpc/grpc-java/blob/master/api/src/main/java/io/grpc/Status.java and you should get it in client.

[benallard]

Sure, but what if I'd like to benefit from the other fields of the other Status ? https://github.com/googleapis/googleapis/blob/master/google/rpc/status.proto That one?

[jvmlet]

Can you please post the example of what you are after with vanilla grpc api ?

[benallard]

Something like that:

             com.google.rpc.Status status = com.google.rpc.Status.newBuilder()
                    .setCode(ALREADY_EXISTS.getNumber())
                    .setMessage("username already taken")
                    .addDetails(Any.pack(ErrorInfo.newBuilder()
                            .setReason("already taken")
                            .setDomain("auth / user")
                            .putMetadata("a", "b")
                            .build()))
                    .build();
            throw StatusProto.toStatusRuntimeException(status);

compare that with:

throw Status.ALREADY_EXISTS
    .withDescription("username already taken")
    .asRuntimeException();

[benallard]

Oh, I see, is that experimental? grpc/grpc-java#4695 for five years now ...

[benallard]

Okay, this is what I ended up with:

    @GRpcExceptionHandler
    public Status handle(MessageException aExc, GRpcExceptionScope aScope) {
        log.error("Exception processing in method {}", aScope.getMethodDescriptor().getFullMethodName());
        ErrorInfo.Builder builder = ErrorInfo.newBuilder()
                .setDomain(itsDomain)
                .setReason(aExc.getReason());
        for (Map.Entry<String, String> entry : aExc.getExtraData().entrySet()) {
            builder.putMetadata(entry.getKey(), entry.getValue());
        }
        com.google.rpc.Status status = com.google.rpc.Status.newBuilder()
                .setCode(aExc.getStatus().getCode().value())
                .setMessage(aExc.getMessage())
                .addDetails(Any.pack(builder.build()))
                .build();
        StatusRuntimeException exception = StatusProto.toStatusRuntimeException(status);
        if (exception.getTrailers() != null) {
            aScope.getResponseHeaders().merge(exception.getTrailers());
        }
        return exception.getStatus();
    }