-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: elastic adaptor #2065
Merged
Merged
feat: elastic adaptor #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziinc
force-pushed
the
feat/log-drains
branch
2 times, most recently
from
May 10, 2024 03:07
cfd9394
to
c980cfd
Compare
Ziinc
force-pushed
the
feat/elastic-adaptor
branch
from
May 16, 2024 05:33
a481ace
to
cd949be
Compare
hauleth
reviewed
May 16, 2024
hauleth
reviewed
May 16, 2024
Coudln't get tesla mocking to work because we would need to mock on a per-client basis, but we dynamically build the client at runtime. Tesla docs doesn't have any guidance on mocking for dynamic clients, and imo would be too much work to get running for the benefit as compared to using mimic. |
@chasers FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in filebeat http handling
It also adds in http1 handling, which the filebeat server requires.
deferred:
Screen.Recording.2024-05-09.at.1.46.56.PM.mov