From a39e58712033830e49eff8d3cbb51f3d502cec2d Mon Sep 17 00:00:00 2001 From: 0liver <0liver@users.noreply.github.com> Date: Tue, 2 Jan 2024 23:48:33 +0100 Subject: [PATCH 1/2] Disable S113 in favor of SA1518 (which has quick-fix action) - both address the lack of a newline character at the end of the file --- Lombiq.Analyzers/Lombiq.Analyzers.globalconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig b/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig index 1054e3ea..221c01ba 100644 --- a/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig +++ b/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig @@ -553,7 +553,7 @@ dotnet_diagnostic.S106.severity = warning dotnet_diagnostic.S107.severity = warning dotnet_diagnostic.S1075.severity = none dotnet_diagnostic.S1109.severity = warning -dotnet_diagnostic.S113.severity = warning +dotnet_diagnostic.S113.severity = none dotnet_diagnostic.S1133.severity = none dotnet_diagnostic.S1144.severity = warning dotnet_diagnostic.S1145.severity = warning @@ -649,7 +649,6 @@ dotnet_diagnostic.SA1503.severity = none dotnet_diagnostic.SA1512.severity = none dotnet_diagnostic.SA1515.severity = none dotnet_diagnostic.SA1516.severity = none -dotnet_diagnostic.SA1518.severity = none dotnet_diagnostic.SA1519.severity = none dotnet_diagnostic.SA1601.severity = none dotnet_diagnostic.SA1602.severity = none From e2ccff2250c05ee4f4e5275c72e849f2d6ad7a86 Mon Sep 17 00:00:00 2001 From: 0liver <0liver@users.noreply.github.com> Date: Tue, 2 Jan 2024 23:51:59 +0100 Subject: [PATCH 2/2] Disable S2344 in favor of CA1711, add comments --- Lombiq.Analyzers/Lombiq.Analyzers.globalconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig b/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig index 221c01ba..b454bc67 100644 --- a/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig +++ b/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig @@ -553,7 +553,7 @@ dotnet_diagnostic.S106.severity = warning dotnet_diagnostic.S107.severity = warning dotnet_diagnostic.S1075.severity = none dotnet_diagnostic.S1109.severity = warning -dotnet_diagnostic.S113.severity = none +dotnet_diagnostic.S113.severity = none # covered by SA1518 dotnet_diagnostic.S1133.severity = none dotnet_diagnostic.S1144.severity = warning dotnet_diagnostic.S1145.severity = warning @@ -577,6 +577,7 @@ dotnet_diagnostic.S2302.severity = warning dotnet_diagnostic.S2330.severity = warning dotnet_diagnostic.S2333.severity = warning dotnet_diagnostic.S2342.severity = warning +dotnet_diagnostic.S2344.severity = none # covered by CA1711 dotnet_diagnostic.S2357.severity = warning dotnet_diagnostic.S2387.severity = warning dotnet_diagnostic.S2437.severity = warning