From a420df254994a2237fd59ec872894fe99c0a7d88 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 25 Dec 2024 01:58:38 +0000 Subject: [PATCH 01/13] Update All packages --- Lombiq.Analyzers.NetFx/Build.props | 2 +- Lombiq.Analyzers/AnalyzerPackages.props | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Lombiq.Analyzers.NetFx/Build.props b/Lombiq.Analyzers.NetFx/Build.props index 27bf9c30..63b2064b 100644 --- a/Lombiq.Analyzers.NetFx/Build.props +++ b/Lombiq.Analyzers.NetFx/Build.props @@ -46,7 +46,7 @@ 'C:\Users\runneradmin\.nuget\packages\microsoft.codeanalysis.csharp.codestyle\4.7.0\analyzers\dotnet\cs\Microsoft.CodeAnalysis.CSharp.CodeStyle.dll' #spell-check-ignore-line references version '4.7.0.0' of the compiler, which is newer than the currently running version '4.6.0.0'." kind. --> - + all runtime; build; native; contentfiles; analyzers; diff --git a/Lombiq.Analyzers/AnalyzerPackages.props b/Lombiq.Analyzers/AnalyzerPackages.props index 5203bcd8..3d31155f 100644 --- a/Lombiq.Analyzers/AnalyzerPackages.props +++ b/Lombiq.Analyzers/AnalyzerPackages.props @@ -6,12 +6,12 @@ - - + + - + - + From 1d4ab3bfb38c959c9633dae8abfef8feff4e03f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 03:23:42 +0100 Subject: [PATCH 02/13] Adjusting rules --- Lombiq.Analyzers/Lombiq.Analyzers.globalconfig | 4 ++++ renovate.json5 | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig b/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig index 05643f6b..0a3a3a4e 100644 --- a/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig +++ b/Lombiq.Analyzers/Lombiq.Analyzers.globalconfig @@ -546,6 +546,8 @@ dotnet_diagnostic.MA0111.severity = none dotnet_diagnostic.MA0120.severity = warning dotnet_diagnostic.MA0121.severity = warning dotnet_diagnostic.MA0122.severity = warning +dotnet_diagnostic.MA0165.severity = silent + # SonarAnalyzer.CSharp rules dotnet_diagnostic.S100.severity = warning @@ -579,6 +581,8 @@ dotnet_diagnostic.S2148.severity = warning dotnet_diagnostic.S2197.severity = warning dotnet_diagnostic.S2278.severity = warning dotnet_diagnostic.S2302.severity = warning +# Covered by CA1822. +dotnet_diagnostic.S2325.severity = none dotnet_diagnostic.S2330.severity = warning dotnet_diagnostic.S2333.severity = warning dotnet_diagnostic.S2342.severity = warning diff --git a/renovate.json5 b/renovate.json5 index 3a027054..0e84282e 100644 --- a/renovate.json5 +++ b/renovate.json5 @@ -14,10 +14,10 @@ 'versioningTemplate': 'nuget' }, ], - 'packageRules': [ + packageRules: [ { - 'groupName': 'All packages', - 'matchUpdateTypes': ['*'], + groupName: 'All packages', + matchUpdateTypes: ['*'], }, ], } From 36dd68cd5c57832239be1a19644c2faf3d64b5f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 03:41:52 +0100 Subject: [PATCH 03/13] Spelling --- renovate.json5 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renovate.json5 b/renovate.json5 index 0e84282e..e799334e 100644 --- a/renovate.json5 +++ b/renovate.json5 @@ -10,7 +10,7 @@ // The capture group names are required as such. '' ], - 'datasourceTemplate': 'nuget', + 'datasourceTemplate': 'nuget', // #spell-check-ignore-lin 'versioningTemplate': 'nuget' }, ], From 2a652fc1775e6e9874e65033308a2eae03ffcd99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 03:44:48 +0100 Subject: [PATCH 04/13] Quote styling --- .github/workflows/test-analysis-failure.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml index 2264d269..9377c562 100644 --- a/.github/workflows/test-analysis-failure.yml +++ b/.github/workflows/test-analysis-failure.yml @@ -12,7 +12,7 @@ jobs: name: Test Analysis Failure - NuGet PackageReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: - machine-types: "['ubuntu-24.04', 'windows-2022']" + machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.PackageReference timeout-minutes: 30 build-expected-code-analysis-errors: | @@ -25,7 +25,7 @@ jobs: name: Test Analysis Failure - Local ProjectReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: - machine-types: "['ubuntu-24.04', 'windows-2022']" + machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.ProjectReference timeout-minutes: 30 build-expected-code-analysis-errors: | From acf877aa41808f799586c719888e825f938f23ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 03:44:59 +0100 Subject: [PATCH 05/13] Trying a newer .NET SDK --- .github/workflows/test-analysis-failure.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml index 9377c562..913dccb9 100644 --- a/.github/workflows/test-analysis-failure.yml +++ b/.github/workflows/test-analysis-failure.yml @@ -12,6 +12,7 @@ jobs: name: Test Analysis Failure - NuGet PackageReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: + dotnet-version: 8.0.307 machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.PackageReference timeout-minutes: 30 From b8c16f57e2591d6fb05c7b9ee8b2164c599428ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 03:45:45 +0100 Subject: [PATCH 06/13] Spelling again --- renovate.json5 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renovate.json5 b/renovate.json5 index e799334e..152e9d03 100644 --- a/renovate.json5 +++ b/renovate.json5 @@ -10,7 +10,7 @@ // The capture group names are required as such. '' ], - 'datasourceTemplate': 'nuget', // #spell-check-ignore-lin + 'datasourceTemplate': 'nuget', // #spell-check-ignore-line 'versioningTemplate': 'nuget' }, ], From 71bc76ccd5cbc9d0f0d8345317dba1b5eaee6b84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 03:51:03 +0100 Subject: [PATCH 07/13] Even newer SDK --- .github/workflows/test-analysis-failure.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml index 913dccb9..07a7bdd5 100644 --- a/.github/workflows/test-analysis-failure.yml +++ b/.github/workflows/test-analysis-failure.yml @@ -12,7 +12,7 @@ jobs: name: Test Analysis Failure - NuGet PackageReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: - dotnet-version: 8.0.307 + dotnet-version: 8.0.404 machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.PackageReference timeout-minutes: 30 From 0a107f2a362f0aa5b1180064205a59e3532113ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 03:56:39 +0100 Subject: [PATCH 08/13] And now .NET 9 --- .github/workflows/test-analysis-failure.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml index 07a7bdd5..ddaac813 100644 --- a/.github/workflows/test-analysis-failure.yml +++ b/.github/workflows/test-analysis-failure.yml @@ -12,7 +12,7 @@ jobs: name: Test Analysis Failure - NuGet PackageReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: - dotnet-version: 8.0.404 + dotnet-version: 9.0.101 machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.PackageReference timeout-minutes: 30 From d6e147e8278fcd88f9879cfaf7a329938b0bacc9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 04:00:34 +0100 Subject: [PATCH 09/13] Set the wrong config --- .github/workflows/test-analysis-failure.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml index ddaac813..e1f36849 100644 --- a/.github/workflows/test-analysis-failure.yml +++ b/.github/workflows/test-analysis-failure.yml @@ -12,7 +12,6 @@ jobs: name: Test Analysis Failure - NuGet PackageReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: - dotnet-version: 9.0.101 machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.PackageReference timeout-minutes: 30 @@ -26,6 +25,7 @@ jobs: name: Test Analysis Failure - Local ProjectReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: + dotnet-version: 9.0.101 machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.ProjectReference timeout-minutes: 30 From e7e4c6ec317cd5949245b07915928950011d3510 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 04:02:16 +0100 Subject: [PATCH 10/13] How about .NET 8.0.404 --- .github/workflows/test-analysis-failure.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml index e1f36849..6adc99b3 100644 --- a/.github/workflows/test-analysis-failure.yml +++ b/.github/workflows/test-analysis-failure.yml @@ -25,7 +25,7 @@ jobs: name: Test Analysis Failure - Local ProjectReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: - dotnet-version: 9.0.101 + dotnet-version: 8.0.404 machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.ProjectReference timeout-minutes: 30 From b0bb336d0f2fb0dcd8d349f3871f25b7e9f6cb62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 04:06:57 +0100 Subject: [PATCH 11/13] How about 4.11.0 --- .github/workflows/test-analysis-failure.yml | 1 - Lombiq.Analyzers/AnalyzerPackages.props | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test-analysis-failure.yml b/.github/workflows/test-analysis-failure.yml index 6adc99b3..9377c562 100644 --- a/.github/workflows/test-analysis-failure.yml +++ b/.github/workflows/test-analysis-failure.yml @@ -25,7 +25,6 @@ jobs: name: Test Analysis Failure - Local ProjectReference uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev with: - dotnet-version: 8.0.404 machine-types: '["ubuntu-24.04", "windows-2022"]' build-directory: TestSolutions/Lombiq.Analyzers.ProjectReference timeout-minutes: 30 diff --git a/Lombiq.Analyzers/AnalyzerPackages.props b/Lombiq.Analyzers/AnalyzerPackages.props index 3d31155f..45596bf8 100644 --- a/Lombiq.Analyzers/AnalyzerPackages.props +++ b/Lombiq.Analyzers/AnalyzerPackages.props @@ -7,7 +7,7 @@ - + From 91c60c16f35187b1afd3760d959ef621f049738f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 04:14:44 +0100 Subject: [PATCH 12/13] Downgrading Microsoft.CodeAnalysis.CSharp.CodeStyle and excluding it from updates --- Lombiq.Analyzers/AnalyzerPackages.props | 2 +- renovate.json5 | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Lombiq.Analyzers/AnalyzerPackages.props b/Lombiq.Analyzers/AnalyzerPackages.props index 45596bf8..4e245aba 100644 --- a/Lombiq.Analyzers/AnalyzerPackages.props +++ b/Lombiq.Analyzers/AnalyzerPackages.props @@ -7,7 +7,7 @@ - + diff --git a/renovate.json5 b/renovate.json5 index 152e9d03..08944b4d 100644 --- a/renovate.json5 +++ b/renovate.json5 @@ -15,6 +15,17 @@ }, ], packageRules: [ + { + // Microsoft.CodeAnalysis.CSharp.CodeStyle references Roslyn, and if its version is higher than that of the + // locally installed SDK, it'll emit a "CSC : error CS9057: The analyzer assembly + // '/home/runner/.nuget/packages/microsoft.codeanalysis.csharp.codestyle/4.11.0/analyzers/dotnet/cs/Microsoft.CodeAnalysis.CSharp.CodeStyle.dll' + // references version '4.31.0.0' of the compiler, which is newer than the currently running version + // '4.10.0.0'." error. So, we need to update it manually together with the SDK (and targeted .NET version). + matchPackageNames: [ + 'Microsoft.CodeAnalysis.CSharp.CodeStyle', + ], + enabled: false, + }, { groupName: 'All packages', matchUpdateTypes: ['*'], From f4835d7ef97cf21f7dd97740fb9d0df9dd19df3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zolt=C3=A1n=20Leh=C3=B3czky?= Date: Wed, 25 Dec 2024 04:22:32 +0100 Subject: [PATCH 13/13] Updating package --- .../Lombiq.Analyzers.PackageReference.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj b/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj index 9dc9242c..c270d16c 100644 --- a/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj +++ b/TestSolutions/Lombiq.Analyzers.PackageReference/Lombiq.Analyzers.PackageReference.csproj @@ -5,7 +5,7 @@ - + all