Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Trumbowyg highlight plugin from NPM (OSOE-947) #189

Open
2 tasks done
Piedone opened this issue Dec 23, 2024 · 1 comment · May be fixed by #190
Open
2 tasks done

Use the Trumbowyg highlight plugin from NPM (OSOE-947) #189

Piedone opened this issue Dec 23, 2024 · 1 comment · May be fixed by #190
Assignees
@Piedone

Comments

@Piedone
Copy link
Member

Piedone commented Dec 23, 2024 •
edited
Loading

Instead of copying the files of the the Trumbowyg highlight plugin (and its dependency Prism), use as a package from NPM.

  • Use the latest package compatible with OC's version and fix any compatibility issues.
  • Use ConstantFromJson from Helpful Libraries instead of hard-coded versions in TrumbowygResourceManagementOptionsConfiguration.

Jira issue
@github-actions github-actions bot changed the title Use the Trumbowyg highlight plugin from NPM Use the Trumbowyg highlight plugin from NPM (OSOE-947) Dec 23, 2024
@Piedone
Copy link
Member Author

Piedone commented Dec 23, 2024

@wAsnk perhaps you'd be interested in this?

@github-actions github-actions bot linked a pull request Jan 4, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Piedone Piedone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OSOE-947: Use the Trumbowyg highlight plugin from NPM Lombiq/Helpful-Extensions
1 participant
@Piedone