Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chart.js to latest (OSOE-944) #87

Open
5 tasks
Piedone opened this issue Dec 23, 2024 · 1 comment
Open
5 tasks

Update Chart.js to latest (OSOE-944) #87

Piedone opened this issue Dec 23, 2024 · 1 comment

Comments

@Piedone
Copy link
Member

Piedone commented Dec 23, 2024

Chart.js v3 and v4 brought breaking changes that the module needs to be adapted to. See migration docs here and here.

  • Open an issue branch from the branch of Update All packages (major) #86.
  • Remove the package-lock file because we'll only use pnpm-lock. Renovate deprecated having both.
  • Make the module (and the sample) compatible with Chart.js v4.
  • Use ConstantFromJson from Helpful Libraries instead of hard-coded versions in ResourceManagementOptionsConfiguration.
  • Remove the temporary "All packages" group from renovate.json5.

After merging the issue branch, #86 should close itself.

Jira issue

@github-actions github-actions bot changed the title Update Chart.js to latest Update Chart.js to latest (OSOE-944) Dec 23, 2024
@Piedone
Copy link
Member Author

Piedone commented Dec 23, 2024

Perhaps something you'd be interested in, @sarahelsaig @dministro?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant