Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current SudoswapProxy implementation cannot handle partial fills when an NFT is no longer available #26

Open
0xhiroshi opened this issue Sep 7, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@0xhiroshi
Copy link
Collaborator

The current SudoswapProxy's partial fill can only handle the case where the pool price moves out of the user's max cost. It will revert during safeTransferFrom if the NFT the user wants to purchase is no longer available.

Sudoswap will release a V2 router and it will be able to handle this scenario by checking that the token IDs are still in the pool before order execution, so we will wait until it goes live before integrating with Sudoswap again.

@0xhiroshi 0xhiroshi self-assigned this Sep 7, 2022
@0xhiroshi 0xhiroshi added the bug Something isn't working label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants
@0xhiroshi and others